8000 BigQuery: Support Tuple syntax in other locations by keraion · Pull Request #6328 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BigQuery: Support Tuple syntax in other locations #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

BigQuery: Support Tuple syntax in other locations #6328

merged 1 commit into from
Oct 10, 2024

Conversation

keraion
Copy link
Contributor
@keraion keraion commented Oct 10, 2024

Brief summary of the change made

This allows for expressions to be in bracketed expressions. Namely used by BigQuery and the tuple syntax.

Are there any other side effects of this change that we should be aware of?

None, as far as I can tell

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18549      0   100%

236 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member
@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit e3aa199 Oct 10, 2024
29 checks passed
@alanmcruickshank alanmcruickshank deleted the bigquery_tuples_with_expressions branch October 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Unparsable section when using multiplication
2 participants
@keraion @alanmcruickshank
0