8000 Switch from `appdirs` to `platformdirs` by alanmcruickshank · Pull Request #6399 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch from appdirs to platformdirs #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 21, 2024
Merged

Switch from appdirs to platformdirs #6399

merged 19 commits into from
Nov 21, 2024

Conversation

alanmcruickshank
Copy link
Member
@alanmcruickshank alanmcruickshank commented Oct 24, 2024 •
edited
Loading

This resolves #6238. Switches from appdirs (which isn't maintained anymore) to platformdirs.

This however involves revisiting our XDG hack. The original test cases weren't very robust, and so a big chunk of this PR is actually making the test cases better (and work with platform_dirs). Coverage is painful here, but I think the approach I've settled on works out ok.

I've added a chunk more comments and docstrings too to help with making it clearer.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 19, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18783      0   100%

243 files skipped due to complete coverage.

@a-detiste
Copy link

Thank you already. The original patch was imported in Debian (with this one failing test disabled)

@alanmcruickshank
Copy link
Member Author

Thank you already. The original patch was imported in Debian (with this one failing test disabled)

My pleasure! This one should be almost ready to go.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 4dc390f Nov 21, 2024
31 checks passed
@alanmcruickshank alanmcruickshank deleted the ac/platformdirs branch November 21, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace deprecated appdirs dependency with platformdirs
3 participants
@alanmcruickshank @a-detiste @greg-finley
0