Support identifier clause for Databricks #6377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+376
to
+391
| class DatabaseReferenceSegment(ObjectReferenceSegment): | ||
| """A reference to a database.""" | ||
|
|
||
| type = "database_reference" | ||
|
|
||
|
|
||
| class TableReferenceSegment(ObjectReferenceSegment): | ||
| """A reference to an table, CTE, subquery or alias.""" | ||
|
|
||
| type = "table_reference" | ||
|
|
||
|
|
||
| class SchemaReferenceSegment(ObjectReferenceSegment): | ||
| """A reference to a schema.""" | ||
|
|
||
| type = "schema_reference" |
There was a problem hiding this comment.
I don't think these need redefining? I can't see any edits vs the classess created in the ansi dialect, so no need to redefine. Unless I've missed something?
There was a problem hiding this comment.
These were needed to inherit changes to ObjectReferenceSegment which has been updated, just tested and without these lines the tests fail.
There was a problem hiding this comment.
iiiiiineresting. Good catch. Not super helpful from a development point of view, but I guess that's what it is right now.
Thanks for the contribution!
Coverage Results ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for IDENTIFIER clause.
Brief summary of the change made
Supports IDENTIFIER(string or string expression) in stead of database, schema, table or view names as per [documentation].(https://docs.databricks.com/en/sql/language-manual/sql-ref-names-identifier-clause.html)
Are there any other side effects of this change that we should be aware of?
Not that I am aware of apologies if I have missed something as this is my first PR.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.