8000 Change evaluation order of literals before column refs in bracketed, delimited expressions by keraion · Pull Request #6117 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change evaluation order of literals before column refs in bracketed, delimited expressions #6117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

keraion
Copy link
Contributor
@keraion keraion commented Aug 28, 2024

Brief summary of the change made

This fixes an issue where some bracketed, delimited expressions were resolving to delimited column references instead of the literal values that they should have been.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor
github-actions bot commented Aug 28, 2024

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18078      0   100%

228 files skipped due to complete coverage.

@coveralls
Copy link
coveralls commented Aug 28, 2024

Coverage Status

coverage: 99.985%. remained the same
when pulling daf59e4 on keraion:delimited_literal_evaluation
into 18293ce on sqlfluff:main.

Copy link
Contributor
@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Aug 28, 2024
Merged via the queue into sqlfluff:main with commit 1a8f884 Aug 28, 2024
30 checks passed
@keraion keraion deleted the delimited_literal_evaluation branch September 5, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule L027 & L057 fails when using a like any statement within a join
3 participants
0