8000 Postgres: Add SHOW Statement by WittierDinosaur · Pull Request #6110 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Postgres: Add SHOW Statement #6110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 8, 2024
Merged

Postgres: Add SHOW Statement #6110

merged 7 commits into from
Sep 8, 2024

Conversation

WittierDinosaur
Copy link
Contributor

Brief summary of the change made

Fixes #5916
Also slight change to the error message when keywords are missing, to make it more user-friendly.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 26, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18140      0   100%

232 files skipped due to complete coverage.

@coveralls
Copy link
coveralls commented Aug 26, 2024 •
edited
Loading

Coverage Status

coverage: 99.985%. remained the same
when pulling 13857c4 on postgres-show-statement
into 9b1b138 on main.

keraion
keraion requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor
@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to specify a new segment to catch all of the numerous available options.

@WittierDinosaur
Copy link
Contributor Author

@keraion i think i was actually just missing ParameterName as an option - I think it now covers it

keraion
keraion approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor
@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keraion keraion added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit 7ca1c2a Sep 8, 2024
32 checks passed
@keraion keraion deleted the postgres-show-statement branch September 8, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Postgres’ extension: SHOW
3 participants
@WittierDinosaur @coveralls @keraion
0