8000 ST03: Detect CTE usage in nested `WITH` clauses by keraion · Pull Request #6017 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ST03: Detect CTE usage in nested WITH clauses #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2024
Merged

ST03: Detect CTE usage in nested WITH clauses #6017

merged 2 commits into from
Aug 9, 2024

Conversation

keraion
Copy link
Contributor
@keraion keraion commented Jul 21, 2024

Brief summary of the change made

This fixes where CTE statements usage was not detected when the use was inside a nested with_compound_statement.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 21, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17938      0   100%

227 files skipped due to complete coverage.

@coveralls
Copy link
coveralls commented Jul 21, 2024 •
edited
Loading

Coverage Status

coverage: 99.985%. remained the same
when pulling 9796310 on keraion:ST03_nested_with_cte
into f08a86e on sqlfluff:main.

felixmccuaig
felixmccuaig approved these changes Jul 22, 2024
View reviewed changes
Copy link
@felixmccuaig felixmccuaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@sdepablos
Copy link

Looks good to me

@sdepablos sdepablos mentioned this pull request Aug 1, 2024
Closed
3 tasks
alanmcruickshank
alanmcruickshank approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member
@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple. There's a chance this has a performance impact, but ST03 is already a fairly fast rule so I'm hoping it's minimal.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Aug 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 9, 2024
@alanmcruickshank alanmcruickshank added this pull request to the merge queue Aug 9, 2024
Merged via the queue into sqlfluff:main with commit 5210291 Aug 9, 2024
30 checks passed
@keraion keraion deleted the ST03_nested_with_cte branch August 11, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

@felixmccuaig felixmccuaig felixmccuaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

structure.unused_cte misses usage in nested CTEs
5 participants
@keraion @coveralls @sdepablos @alanmcruickshank @felixmccuaig
0