8000 Fix TSQL Post Table Expr intrepreted as function by ulixius9 · Pull Request #6001 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix TSQL Post Table Expr intrepreted as function #6001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

Fix TSQL Post Table Expr intrepreted as function #6001

merged 2 commits into from
Jul 5, 2024

Conversation

ulixius9
Copy link
Contributor
@ulixius9 ulixius9 commented Jul 5, 2024

The post table expression (without the optional WITH keyword) would be treated as a function, this pr prioritises parsing post table expression before matching with functions.

FROM dbo.tableX (NOLOCK)

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 5, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17901      0   100%

227 files skipped due to complete coverage.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling eda16fb on ulixius9:post_table_expr
into 3ef765d on sqlfluff:main.

@coveralls
Copy link

Coverage Status

coverage: 99.985%. remained the same
when pulling bd329c7 on ulixius9:post_table_expr
into 3ef765d on sqlfluff:main.

WittierDinosaur
WittierDinosaur approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor
@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jul 5, 2024
Merged via the queue into sqlfluff:main with commit 1e75212 Jul 5, 2024
30 checks passed
@SumanMaharana SumanMaharana mentioned this pull request Aug 11, 2024
Closed
@reata reata mentioned this pull request Mar 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulixius9 @coveralls @WittierDinosaur
0