8000 Fixed exit status handling in example validation for specFile and examplesDir combination by mik047 · Pull Request #1840 · specmatic/specmatic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed exit status handling in example validation for specFile and examplesDir combination #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Fixed exit status handling in example validation for specFile and examplesDir combination #1840

merged 1 commit into from
May 23, 2025

Conversation

mik047
Copy link
Contributor
@mik047 mik047 commented May 23, 2025

What:

In examples validate command, now for each of the five parameter combinations (to accept spec and/or examples), the hook result is also honoured in overall exit status of the process.

Checklist:

  • [/] Unit Tests
  • [/] Build passing locally
  • Sonar Quality Gate
  • Security scans don't report any vulnerabilities
  • Documentation added/updated (share link)
  • Sample Project added/updated (share link)
  • Demo video (share link)
  • Article on Website (share link)
  • Roadmpap updated (share link)
  • Conference Talk (share link)

@mik047
8000 fix(ExamplesCommand): improve exit status handling in example validat…
8eede40 
…ion for specFile and examplesDir combination
@mik047 mik047 requested a review from joelrosario May 23, 2025 11:41
@joelrosario joelrosario merged commit f37fa29 into main May 23, 2025
1 check passed
@joelrosario joelrosario deleted the fix_validate_examples_exit_status branch May 23, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrosario joelrosario joelrosario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mik047 @joelrosario
0