8000 Fix dictionary usage for positive mutated object patterns by StarKhan6368 · Pull Request #1837 · specmatic/specmatic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix dictionary usage for positive mutated object patterns #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Fix dictionary usage for positive mutated object patterns #1837

merged 3 commits into from
May 22, 2025

Conversation

StarKhan6368
Copy link
Contributor

What: Fix dictionary usage for positive mutated object patterns

Why: Positive mutated patterns can remove optional keys; however, if the dictionary value includes these optional keys, it can lead to issues when generating test scenarios

How: Remove optional keys if the object's structure has been positively altered to exclude them

Checklist:

  • Unit Tests
  • Build passing locally
  • Sonar Quality Gate
  • Security scans don't report any vulnerabilities
  • Documentation added/updated (share link)
  • Sample Project added/updated (share link)
  • Demo video (share link)
  • Article on Website (share link)
  • Roadmpap updated (share link)
  • Conference Talk (share link)

@StarKhan6368
Add removeKeys to Pattern.fillInTheBlanks
daedc74 
- Removes any keys from valueToBe filledIn that are not present
  in patternMap at the time of filling in
- Defaults to false
@StarKhan6368
Remove extraKeys when fillingIn dictionaryValue
4db73c4
@StarKhan6368
Test for postiveMutation using dictionary
cbbf010
@StarKhan6368 StarKhan6368 marked this pull request as ready for review May 22, 2025 14:15
@joelrosario joelrosario merged commit 8662328 into main May 22, 2025
1 check passed
@joelrosario joelrosario deleted the fix-dict-fill-in branch May 22, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrosario joelrosario joelrosario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarKhan6368 @joelrosario
0