Implement support for logical AND in security schemes #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Represent `AND` relationship between securitySchemes in OAS - Add simple tests for the same
- logical `AND` with multiple security-schemes is represented by CompositeSecurityScheme - Add tests for the same
- Should send appropriate security-scheme values based on the OAS
- Mimics what isInRow does, but with HttpRequest instead
- Should only ignore failures if none of the schemes areIn request - Add test for the same
- For composite logical AND/OR security schemes
- Only applicable to compositeScheme to check if all or any of sub-schemes are in a request
- To better handle multiple and composite schemes
- Update the tests accordingly
joelrosario
reviewed
May 22, 2025
| schemeName to toSecurityScheme(schemeName, scheme) | ||
| } | ||
|
|
||
| val securitySchemesForRequestPattern = parseOperationSecuritySchemas(operation) { name -> |
There was a problem hiding this comment.
Why not pass the securitySchemes directly instead of a function?
joelrosario
reviewed
May 22, 2025
core/src/main/kotlin/io/specmatic/conversions/APIKeyInHeaderSecurityScheme.kt
Show resolved
Hide resolved
joelrosario
reviewed
May 22, 2025
…he security scheme implementation classes
…seOperationSecuritySchemas
joelrosario
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Implement support for logical AND in security schemes
Why:
ORbetween the security schemes defined in theOAS.Sources:
Checklist:
Issue ID:
Closes: #932