BREAKING CHANGE: Improved parsing and tokenization of filters #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Removed support for wildcard char from STATUS filter
- Updated filter integration test cases
- Updated ScenarioMetadataFilter tests
- Removed support for wildcard char from STATUS filter
- Values are now directly passed to the EnhancedRHSValueEval function
- Updated tests for custom eFunc filter
- Extracted filter operator and expression building logic
* Improved the test coverage of the expression parser. * Improved the implementation of `ExpressionStandardizer` by reducing the primitive obsession. * Removed unwanted tests from `ScenarioMetadataFilterTests` that were moved into `ExpressionStandardizer` * Introduced a more specific expression evaluator for `includes`. This will be responsible for checks like `FOO=a,b,c` and `FOO!=a,b,c`. This logic was earlier inside `EnhancedRHSValueEvalFunction`
- Removed support for wildcard char from STATUS filter - Updated filter integration test cases - Updated ScenarioMetadataFilter tests
- Removed support for wildcard char from STATUS filter - Values are now directly passed to the EnhancedRHSValueEval function
- Extracted filter operator and expression building logic - Updated tests for custom eFunc filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.