-
-
Notifications
You must be signed in to change notification settings - Fork 567
Docs redesign #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patriksvensson
merged 13 commits into
spectreconsole:main
from
phil-scott-78:docs-snippets
Feb 14, 2022
Merged
Docs redesign #728
patriksvensson
merged 13 commits into
spectreconsole:main
from
phil-scott-78:docs-snippets
Feb 14, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusting the pipeline to look at fewer files
Works better when looking for the body of text. Removed support for highlighting the definition only for now
btw, feel free to squash this. The journey to where I ended up is all over the place. Not a ton of value in saving that history. |
patriksvensson
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot have changed, but build is passing so 👍
This was referenced Mar 27, 2022
Merged
This was referenced Mar 27, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the whole redesign and completely lacks the reason I started it in the first place - adding in the documentation snippets. It might take a bit to get that nailed down because it'll require some reworking of the examples to make them a bit more documentation ready. A lot of good in what's already here so no sense waiting on that I suppose.