8000 Strong name the assemblies by KirillOsenkov · Pull Request #1623 · spectreconsole/spectre.console · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Strong name the assemblies #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Strong name the assemblies #1623

merged 1 commit into from
Aug 30, 2024

Conversation

KirillOsenkov
Copy link
Contributor

Revival of #687

fixes #481

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Adds a strong name key pair and signs all assemblies using the .snk file. Temporarily suppresses one warning until Spectre.Verify.Extensions is signed (in a separate PR).

Please upvote 👍 this pull request if you are interested in it.

@KirillOsenkov
Copy link
Contributor Author

Huge thanks to @sebastienros for the original PR.

@sebastienros
Copy link

Yours is better, you know how to use msbuild ;)

@KirillOsenkov
Copy link
Contributor Author

Companion PR: spectresystems/spectre.verify.extensions#10

Once that merges and we update Spectre.Verify.Extensions in this repo, we can remove the NoWarn here:
https://github.com/KirillOsenkov/spectre.console/blob/6116af384458dc6acc7b887617e7aec45c703d86/src/Tests/Directory.Build.props#L8

I was also wondering why there's a separate Directory.Build.props in the Tests directory. All the three properties that it sets are already set by the parent. However the parent Directory.Build.props will not be automatically imported. If you want it to be imported you need to add: <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props'))" />

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Aug 30, 2024
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
Open
@patriksvensson patriksvensson merged commit 7af1eed into spectreconsole:main Aug 30, 2024
3 checks passed
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@KirillOsenkov KirillOsenkov deleted the dev/kirillo/snk branch August 30, 2024 06:04
kzu added a commit to kzu/spectre.console that referenced this pull request Sep 5, 2024
@kzu
Simplify InternalsVisibleTo
f94691f 
If the $(PublicKey) property is used, the SDK targets will automatically use it for the assembly attributes.

See dotnet/sdk#3439

Simplifies spectreconsole#1623
< 9712 div > @kzu kzu mentioned this pull request Sep 5, 2024
Merged
patriksvensson pushed a commit that referenced this pull request Sep 6, 2024
@kzu @patriksvensson
Simplify InternalsVisibleTo
8e44a83 
If the $(PublicKey) property is used, the SDK targets will automatically use it for the assembly attributes.

See dotnet/sdk#3439

Simplifies #1623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriksvensson patriksvensson patriksvensson approved these changes

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
⭐ top pull request Top pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StrongNamed version of the assembly
3 participants
@KirillOsenkov @sebastienros @patriksvensson
0