fix: blob.py 2d intensities shape and pd.concat instead of append #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
starfish/core/spots/FindSpots/blob.py:151
- Verify that 'z_inds' is properly defined and matches the dimensions of data_image to avoid unexpected index errors.
intensities = data_image[tuple([z_inds, y_inds, x_inds])]
starfish/core/spots/FindSpots/blob.py:218
- [nitpick] Consider explicitly specifying the 'axis' parameter (axis=0) in pd.concat() to ensure consistent row-wise concatenation, especially if DataFrame dimensions might vary.
merged_z_tables[(r, ch)] = pd.concat([merged_z_tables[(r, ch)], spot_attributes_list[i][0].spot_attrs.data])
berl
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2003
Fixed 2 bugs in blob.py that were discovered when running the BlobDetector how-to example:
https://spacetx-starfish.readthedocs.io/en/latest/gallery/how_to/blob_detector.html#howto-blobdetector
intensitiesin 2d by adding the indexz_indsas it is still used although it is set to zero.