[easy] Clip method for Richardson Lucy #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Richardson Lucy deconv was not passing the user-requested clip method to `apply()`. This PR adds the missing parameter, and adjusts the expected results accordingly. As a bonus, the coefficient goes up a bit! Test plan: `pytest starfish/test/full_pipelines/api/test_merfish.py`
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
=======================================
Coverage 90.21% 90.21%
=======================================
Files 225 225
Lines 8694 8694
=======================================
Hits 7843 7843
Misses 851 851
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Nov 22, 2019
ttung
pushed a commit
that referenced
this pull request
Dec 3, 2019
Adjusts all the filters to use levels instead of clip/preserve_float_range. `clip_method` is still supported though deprecated. If both are provided, an exception is thrown. If `clip_method` by itself is provided, then a deprecation warning is printed and the `clip_method` is translated to the appropriate `levels_method`. Depends on #1666, #1668 Test plan: this is an -alltest branch since it affects so much code. if goes green, we should presumably be good. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Richardson Lucy deconv was not passing the user-requested clip method to
apply(). This PR adds the missing parameter, and adjusts the expected results accordingly. As a bonus, the coefficient goes up a bit!Test plan:
pytest starfish/test/full_pipelines/api/test_merfish.py