Use ArrayLike where appropriate. #1650

ttung · 2019-11-13T19:25:43Z

Mostly this is a no-op in terms of complexity, but we got rid of one ugly cast! Later on, we'll also get some benefits from segmentation code.

Depends on #1649
Test plan: make -j lint mypy

codecov-io · 2019-11-13T19:43:53Z

Codecov Report

Merging #1650 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
- Coverage   89.69%   89.69%   -0.01%     
==========================================
  Files         220      220              
  Lines        8236     8235       -1     
==========================================
- Hits         7387     7386       -1     
  Misses        849      849

Impacted Files	Coverage Δ
starfish/core/imagestack/imagestack.py	`93.2% <ø> (ø)`	⬆️
starfish/core/image/Segment/watershed.py	`96.55% <100%> (ø)`	⬆️
...tarfish/core/morphology/label_image/label_image.py	`89.39% <100%> (ø)`	⬆️
starfish/core/imagestack/parser/tileset/_parser.py	`83.54% <100%> (ø)`	⬆️
...arfish/core/segmentation_mask/segmentation_mask.py	`68.42% <100%> (ø)`	⬆️
starfish/core/image/Filter/reduce.py	`100% <100%> (ø)`	⬆️
starfish/core/morphology/binary_mask/_io.py	`85.32% <100%> (ø)`	⬆️
...tarfish/core/morphology/binary_mask/binary_mask.py	`88.17% <100%> (ø)`	⬆️
starfish/core/imagestack/parser/numpy/__init__.py	`87.87% <100%> (-0.19%)`	⬇️
starfish/core/imagestack/parser/crop.py	`90.16% <100%> (ø)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737214f...787b544. Read the comment docs.

Mostly this is a no-op in terms of complexity, but we got rid of one ugly cast! Later on, we'll also get some benefits from segmentation code. Test plan: make -j lint mypy

ttung requested a review from shanaxel42 November 13, 2019 19:25

ttung mentioned this pull request Nov 13, 2019

Improve coordinate handling code for BinaryMaskCollection and LabelImage #1632

Merged

ttung force-pushed the tonytung-arraylike branch from ca699bc to af5f766 Compare November 13, 2019 20:53

ttung force-pushed the tonytung-use-arraylike branch 3 times, most recently from 5b57c14 to 63d6821 Compare November 15, 2019 23:45

shanaxel42 approved these changes Nov 16, 2019

View reviewed changes

ttung force-pushed the tonytung-arraylike branch from 06962de to c578cc2 Compare November 16, 2019 00:21

ttung force-pushed the tonytung-use-arraylike branch 2 times, most recently from 061d083 to 81332f5 Compare November 17, 2019 22:11

ttung changed the base branch from tonytung-arraylike to tonytung-object November 17, 2019 22:14

ttung force-pushed the tonytung-use-arraylike branch 2 times, most recently from f8ffb1e to 1e1458b Compare November 18, 2019 18:53

ttung changed the base branch from tonytung-object to master November 18, 2019 18:53

Use ArrayLike where appropriate.

787b544

Mostly this is a no-op in terms of complexity, but we got rid of one ugly cast! Later on, we'll also get some benefits from segmentation code. Test plan: make -j lint mypy

ttung force-pushed the tonytung-use-arraylike branch from 1e1458b to 787b544 Compare November 18, 2019 20:55

ttung merged commit 2207d1b into master Nov 18, 2019

ttung deleted the tonytung-use-arraylike branch November 18, 2019 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ArrayLike where appropriate. #1650

Use ArrayLike where appropriate. #1650

Use ArrayLike where appropriate. #1650

Use ArrayLike where appropriate. #1650

Conversation

Codecov Report