8000 Remove deprecated code by ttung · Pull Request #1621 · spacetx/starfish · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated code #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Remove deprecated code #1621

merged 1 commit into from
Oct 24, 2019

Conversation

ttung
Copy link
Collaborator
@ttung ttung commented Oct 18, 2019
  1. MaxProject filter. Deprecated since 0.1.2 (june 19)
  2. remove enable_inplace_mode. Deprecated since 0.1.4 (july 17)
  3. remove FieldOfView.show_aligned_image_groups and FieldOfView.iterate_image_type. Deprecated since 0.1.4 (july 17)

@ttung ttung requested a review from shanaxel42 October 18, 2019 21:46
@ttung ttung force-pushed the tonytung-rm-mp branch 2 times, most recently from 319e454 to 6593496 Compare October 18, 2019 22:11
1. MaxProject filter.  Deprecated since 0.1.2 (june 19)
2. remove `enable_inplace_mode`.  Deprecated since 0.1.4 (july 17)
3. remove `FieldOfView.show_aligned_image_groups` and `FieldOfView.iterate_image_type`.  Deprecated since 0.1.4 (july 17)
@ttung ttung changed the title Remove MaxProject filter Remove deprecated code Oct 18, 2019
@codecov-io
Copy link
codecov-io commented Oct 18, 2019

Codecov Report

Merging #1621 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
- Coverage   87.97%   87.95%   -0.02%     
==========================================
  Files         156      155       -1     
  Lines        5472     5448      -24     
==========================================
- Hits         4814     4792      -22     
+ Misses        658      656       -2
Impacted Files Coverage Δ
starfish/core/image/Filter/__init__.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6facac...18be171. Read the comment docs.

@ttung ttung merged commit 421ad08 into master Oct 24, 2019
@ttung ttung deleted the tonytung-rm-mp branch October 24, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0