8000 Replace most instances of starfish.image.Filter.Reduce with imagestack.reduce by ttung · Pull Request #1548 · spacetx/starfish · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace most instances of starfish.image.Filter.Reduce with imagestack.reduce #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

Replace most instances of starfish.image.Filter.Reduce with imagestack.reduce #1548

merged 1 commit into from
Oct 10, 2019

Conversation

ttung
Copy link
Collaborator
@ttung ttung commented Sep 13, 2019 •
edited
Loading

Unless the reduction is happening multiple times, it's simpler to represent a stack reduction as imagestack.reduce

Test plan: travis thanks!
Depends on #1539

@codecov-io
Copy link
codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #1548 into master will increase coverage by 1.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1548      +/-   ##
=========================================
+ Coverage   88.25%     90%   +1.74%     
=========================================
  Files         152     223      +71     
  Lines        5245    8261    +3016     
=========================================
+ Hits         4629    7435    +2806     
- Misses        616     826     +210
Impacted Files Coverage Δ
...core/spots/DetectSpots/test/test_synthetic_data.py 100% <0%> (ø)
starfish/core/experiment/test/test_experiment.py 100% <0%> (ø)
...y_table/test/test_intensity_table_serialization.py 100% <0%> (ø)
...tarfish/core/segmentation_mask/test/test_expand.py 100% <0%> (ø)
starfish/core/imagestack/test/test_export.py 100% <0%> (ø)
...intensity_table/test/test_synthetic_intensities.py 100% <0%> (ø)
...rfish/core/intensity_table/test/test_to_mermaid.py 100% <0%> (ø)
starfish/core/test/factories.py 88.97% <0%> (ø)
...sh/core/expression_matrix/test/test_concatenate.py 100% <0%> (ø)
starfish/core/test/test_synthetic_spot_creation.py 100% <0%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf1d96...f612f8a. Read the comment docs.

@ttung ttung force-pushed the tonytung-use-map-reduce branch from d79996f to 3ed6556 Compare September 13, 2019 17:09
@ttung ttung mentioned this pull request Sep 13, 2019
Merged
@ttung ttung force-pushed the tonytung-use-map-reduce branch from 3ed6556 to 23f18ee Compare September 13, 2019 17:22
@ttung ttung force-pushed the tonytung-map-reduce branch from 18ebbc3 to cf4f2ec Compare September 16, 2019 19:16
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 7bc8d76 to 5c4b77f Compare September 16, 2019 20:51
@ttung ttung force-pushed the tonytung-map-reduce branch from 5757961 to df5f44a Compare September 16, 2019 20:53
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 3b40109 to 55a84f3 Compare September 16, 2019 20:57
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from fa479cb to 87b6956 Compare September 18, 2019 17:56
@ttung ttung force-pushed the tonytung-map-reduce branch from 1436e1e to f42a001 Compare September 18, 2019 18:57
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 755a67d to 8216d33 Compare September 18, 2019 21:24
@ttung ttung force-pushed the tonytung-map-reduce branch from 01a3e6c to e2bc37e Compare September 18, 2019 21:26
@ttung ttung force-pushed the tonytung-use-map-reduce branch 3 times, most recently from 873a327 to a108ce5 Compare September 18, 2019 22:53
@ttung ttung force-pushed the tonytung-map-reduce branch from 8c21e24 to b187a24 Compare September 20, 2019 00:49
@ttung ttung force-pushed the tonytung-use-map-reduce branch from a108ce5 to 23fd1e6 Compare September 20, 2019 00:49
@ttung ttung force-pushed the tonytung-map-reduce branch from b187a24 to 0bfbd65 Compare September 20, 2019 00:53
@ttung ttung force-pushed the tonytung-use-map-reduce branch from 23fd1e6 to 07f27d0 Compare September 20, 2019 00:53
@ttung ttung force-pushed the tonytung-map-reduce branch from 0bfbd65 to 64d5322 Compare September 20, 2019 01:09
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 40d8e4e to 7fd6a53 Compare September 20, 2019 01:48
@ttung ttung force-pushed the tonytung-use-map-reduce branch from 53c5be7 to b620e73 Compare September 24, 2019 18:12
@ttung ttung force-pushed the tonytung-map-reduce branch from de1c6fe to 9e47685 Compare September 27, 2019 17:53
@ttung ttung force-pushed the tonytung-use-map-reduce branch from b620e73 to 0da0bcb Compare September 27, 2019 17:53
@ttung ttung force-pushed the tonytung-map-reduce branch from 9e47685 to e82ef53 Compare October 1, 2019 03:18
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 3380d78 to 88261ac Compare October 1, 2019 05:06
@ttung ttung force-pushed the tonytung-map-reduce branch from 6360be6 to f08a569 Compare October 2, 2019 06:16
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 1a6f306 to 28d15b0 Compare October 4, 2019 17:53
@ttung ttung force-pushed the tonytung-map-reduce branch from 2210ee2 to b7d9351 Compare October 8, 2019 22:31
@ttung ttung force-pushed the tonytung-use-map-reduce branch from 28d15b0 to 8e93d48 Compare October 8, 2019 22:31
@ttung ttung force-pushed the tonytung-map-reduce branch from b7d9351 to da9a140 Compare October 9, 2019 20:22
@ttung ttung force-pushed the tonytung-use-map-reduce branch from 8e93d48 to 28dfbae Compare October 9, 2019 20:22
@ttung ttung force-pushed the tonytung-map-reduce branch from da9a140 to 5f3aa70 Compare October 9, 2019 21:01
@ttung ttung force-pushed the tonytung-use-map-reduce branch 3 times, most recently from ff2af22 to a180d72 Compare October 9, 2019 21:21
@ttung ttung force-pushed the tonytung-map-reduce branch from 5862e96 to 637236b Compare October 9, 2019 23:56
@ttung ttung force-pushed the tonytung-use-map-reduce branch 2 times, most recently from 599453e to aa5a5d0 Compare October 10, 2019 00:03
@ttung ttung changed the base branch from tonytung-map-reduce to master October 10, 2019 06:16
@ttung ttung force-pushed the tonytung-use-map-reduce branch 5 times, most recently from c8858c4 to 7cd93ae Compare October 10, 2019 17:45
Replace most instances of starfish.image.Filter.Reduce with imagestac…
f612f8a 
…k.reduce

Unless the reduction is happening multiple times, it's simpler to represent a stack reduction as imagestack.reduce

Test plan: travis thanks!
@ttung ttung force-pushed the tonytung-use-map-reduce branch from 7cd93ae to f612f8a Compare October 10, 2019 19:58
@ttung ttung merged commit 3cd0df6 into master Oct 10, 2019
@ttung ttung deleted the tonytung-use-map-reduce branch October 10, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanaxel42 shanaxel42 shanaxel42 approved these changes

@ambrosejcarr ambrosejcarr Awaiting requested review from ambrosejcarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @shanaxel42
0