10000 Update the documentation for data formatters by ttung · Pull Request #1476 · spacetx/starfish · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the documentation for data formatters #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

Update the documentation for data formatters #1476

merged 1 commit into from
Jul 30, 2019

Conversation

ttung
Copy link
Collaborator
@ttung ttung commented Jul 30, 2019
  • rewrite the top-level doc for data format.
  • split the TileFetcher docs to a separate doc.
  • link to the structured data formatter and the TileFetcher examples.

Test plan: https://spacetx-starfish.readthedocs.io/en/tonytung-format-docs/getting_started/formatting_data/index.html

Update the documentation for data formatters
e00ba45 
- rewrite the top-level doc for data format.
- split the TileFetcher docs to a separate doc.
- link to the structured data formatter and the TileFetcher examples.

Test plan: https://spacetx-starfish.readthedocs.io/en/tonytung-format-docs/getting_started/formatting_data/index.html
@ttung ttung requested review from neuromusic and ambrosejcarr July 30, 2019 16:25
@codecov-io
Copy link
codecov-io commented Jul 30, 2019 •
edited
Loading
8000

Codecov Report

Merging #1476 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1476   +/-   ##
======================================
  Coverage    87.1%   87.1%           
======================================
  Files         139     139           
  Lines        4985    4985           
======================================
  Hits         4342    4342           
  Misses        643     643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b8a12...e00ba45. Read the comment docs.

neuromusic
neuromusic approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator
@neuromusic neuromusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttung ttung merged commit b7584a6 into master Jul 30, 2019
@ttung ttung deleted the tonytung-format-docs branch July 30, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuromusic neuromusic neuromusic approved these changes

@shanaxel42 shanaxel42 shanaxel42 approved these changes

@ambrosejcarr ambrosejcarr Awaiting requested review from ambrosejcarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ttung @codecov-io @neuromusic @shanaxel42
0