Move the registration tests next to their sources. #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
+ Coverage 89.82% 90.36% +0.54%
==========================================
Files 126 124 -2
Lines 4600 4516 -84
==========================================
- Hits 4132 4081 -51
+ Misses 468 435 -33
Continue to review full report at Codecov.
|
90912c0 to
2839411
Compare
2839411 to
d4b5ebe
Compare
1. Group `_apply_transform` and `_learn_transform` into a `_registration` package. This is because there is common code to the two (basically `TransformsList`). 2. Move tests into each package. `test_registration.py` is broken up into multiple files, each tied to the package they reside in. 3. Ninja'd in the removal of `starfish/spots/test/__init__.py`. Not even sure why that's there.
d4b5ebe to
4d55269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code started before #1111 landed, so it stuck with the older convention.
_apply_transformand_learn_transforminto a_registrationpackage. This is because there is common code to the two (basicallyTransformsList).test_registration.pyis broken up into multiple files, each tied to the package they reside in.starfish/spots/test/__init__.py. Not even sure why that's there.