Follow up of JP-3917: Apply code style rules to lib #9423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9423 +/- ##
==========================================
+ Coverage 75.99% 76.57% +0.58%
==========================================
Files 368 364 -4
Lines 37020 36626 -394
==========================================
- Hits 28133 28047 -86
+ Misses 8887 8579 -308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| try: | ||
| step = Step.from_config_file(path.join(config_path, config_file)) | ||
| step = Step.from_config_file(str(config_path / config_file)) |
There was a problem hiding this comment.
There was a problem hiding this comment.
p.s. Usually the os.path to pathlib.Path updates are just busy-work but it does seem to simplify the code a little in this case.
|
RT https://github.com/spacetelescope/RegressionTests/actions/runs/14742902470/job/41384736743 is red but I don't see how it can be related, and I also cannot compare to |
I cleared the sonar issues and am rerunning the scheduled run now. |
|
Thanks! Re-running 🤞 https://github.com/spacetelescope/RegressionTests/actions/runs/14759149527 |
|
RT and CI passed. This is ready for review. Thanks! |
unlike what it claims in upstream doc
|
Huh. CI passed and 2 approvals. Why does it still say merging is blocked? |
|
Approval by Melanie or Tyler is required |
This PR is a follow-up of #9283 . I skipped some rules back then and said I would follow up later with smaller diff that is easier to review. Does this need a JIRA ticket? Not sure.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files