8000 Fix a bug in resampled_wcs_from_models by mcara · Pull Request #9186 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix a bug in resampled_wcs_from_models #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix a bug in resampled_wcs_from_models #9186

merged 2 commits into from
Feb 13, 2025

Conversation

mcara
Copy link
Member
@mcara mcara commented Feb 12, 2025 •
edited
Loading

Fixes a minor bug in resampled_wcs_from_models with an unused function input parameter being left inadvertently in the code. Simplified the code.

Closes #9185

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • 8000 if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@mcara mcara added this to the Build 11.3 milestone Feb 12, 2025
@mcara mcara self-assigned this Feb 12, 2025
@mcara mcara requested review from a team as code owners February 12, 2025 22:16
@mcara mcara force-pushed the fix-resample-outputwcs-bug branch from 4aced45 to c561bde Compare February 12, 2025 22:22
@mcara
Copy link
Member Author
mcara commented Feb 12, 2025

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/13296066063

emolter
emolter requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator
@emolter emolter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the removal of the wcs_bbox_from_shape import is causing issues elsewhere, where there are instances of resample_utils.wcs_bbox_from_shape() being called.

@codecov Codecov
Copy link
codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.67%. Comparing base (949bd75) to head (6f80991).
Report is 752 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9186      +/-   ##
==========================================
- Coverage   73.68%   73.67%   -0.01%     
==========================================
  Files         372      372              
  Lines       37096    37089       -7     
==========================================
- Hits        27333    27327       -6     
+ Misses       9763     9762       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcara mcara force-pushed the fix-resample-outputwcs-bug branch from 0904f39 to 6f80991 Compare February 12, 2025 23:14
kmacdonald-stsci
kmacdonald-stsci approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor
@kmacdonald-stsci kmacdonald-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a test added for these changes?

@mcara
Copy link
Member Author
mcara commented Feb 13, 2025

Does this need a test added for these changes?

Probably the best and most logical place for a test would be in stcal that tests wcs_from_sregions and provide it a ref_wcs with ref_wcs.bounding_box=None. If such a test already exists there, then I do not think it is needed here.

@emolter emolter self-requested a review February 13, 2025 16:15
emolter
emolter approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator
@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my questions are answered, thanks Mihai

melanieclarke
melanieclarke approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@melanieclarke melanieclarke merged commit 0a2231a into spacetelescope:main Feb 13, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melanieclarke melanieclarke melanieclarke approved these changes

@emolter emolter emolter approved these changes

@kmacdonald-stsci kmacdonald-stsci kmacdonald-stsci approved these changes

@braingram braingram Awaiting requested review from braingram

Assignees

@mcara mcara

Labels
bug resample
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.

refwcs argument to resampled_wcs_from_models is overwritten
4 participants
@mcara @melanieclarke @emolter @kmacdonald-stsci
0