8000 Apply code style rules to datamodels submodule by emolter · Pull Request #9131 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Apply code style rules to datamodels submodule #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 6, 2025
Merged

Apply code style rules to datamodels submodule #9131

merged 15 commits into from
Feb 6, 2025

Conversation

emolter
Copy link
Collaborator
@emolter emolter commented Feb 3, 2025 •
edited
Loading

Partially resolves JP-3860

This PR updates the datamodels/ portion of the jwst repository to comply with the new code style rules.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@emolter
Copy link
Collaborator Author
emolter commented Feb 3, 2025 •
edited
Loading

regtests started here https://github.com/spacetelescope/RegressionTests/actions/runs/13121888293

edit: failures match main

@emolter emolter added this to the Build 11.3 milestone Feb 3, 2025
@stscijgbot-jp stscijgbot-jp mentioned this pull request Feb 3, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.64516% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.77%. Comparing base (b37da9e) to head (717bbad).
Report is 825 commits behind head on main.

Files with missing lines Patch % Lines
jwst/datamodels/container.py 81.57% 7 Missing ⚠️
jwst/datamodels/source_container.py 50.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9131      +/-   ##
==========================================
- Coverage   77.60%   73.77%   -3.83%     
==========================================
  Files         509      372     -137     
  Lines       46734    37273    -9461     
==========================================
- Hits        36267    27498    -8769     
+ Misses      10467     9775     -692
Flag Coverage Δ
nightly ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter marked this pull request as ready for review February 3, 2025 21:33
@emolter emolter requested review from a team as code owners February 3, 2025 21:33
@emolter emolter changed the title Apply code style checks to datamodels submodule Apply code style rules to datamodels submodule Feb 4, 2025
melanieclarke
melanieclarke reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple questions for my information.

I'll defer approval to give Brett a chance to review.

braingram
braingram approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator
@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

melanieclarke
melanieclarke previously approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melanieclarke melanieclarke dismissed their stale review February 6, 2025 19:30

Missed failing test

@melanieclarke
Copy link
Collaborator

Looks like merging from main introduced a small issue with a docstring. When that's fixed, this should be good to go.

@emolter emolter force-pushed the JP-3860-datamodels branch from 0339545 to c36923e Compare February 6, 2025 20:01
@emolter
Copy link
Collaborator Author
emolter commented Feb 6, 2025

While fixing that, I noticed that the new on_disk @property was missing a test. Added it here c36923e

@emolter emolter requested a review from melanieclarke February 6, 2025 20:04
@melanieclarke melanieclarke merged commit 695d774 into spacetelescope:main Feb 6, 2025
30 checks passed
@emolter emolter deleted the JP-3860-datamodels branch February 6, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

@melanieclarke melanieclarke melanieclarke approved these changes

Assignees
No one assigned
Labels
datamodels no-changelog-entry-needed testing
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@emolter @melanieclarke @braingram
0