8000 Apply code style rules to tweakreg by emolter · Pull Request #9130 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Apply code style rules to tweakreg #9130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 5, 2025
Merged

Apply code style rules to tweakreg #9130

merged 15 commits into from
Feb 5, 2025

Conversation

emolter
Copy link
Collaborator
@emolter emolter commented Feb 3, 2025 •
edited
Loading

Partially Resolves JP-3860

This PR applies the code style rules to the tweakreg submodule.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@emolter
Copy link
Collaborator Author
emolter commented Feb 3, 2025

Regression tests here

@stscijgbot-jp stscijgbot-jp mentioned this pull request Feb 3, 2025
Closed
@emolter emolter added this to the Build 11.3 milestone Feb 3, 2025
@emolter emolter requested a review from braingram February 3, 2025 17:09
@codecov Codecov
Copy link
codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.90909% with 30 lines in your changes missing coverage. Please review.

Project coverage is 73.76%. Comparing base (f3cf9a6) to head (2394a6c).
Report is 870 commits behind head on main.

Files with missing lines Patch % Lines
jwst/tweakreg/tweakreg_step.py 59.57% 19 Missing ⚠️
jwst/tweakreg/tweakreg_catalog.py 64.28% 10 Missing ⚠️
jwst/tweakreg/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9130      +/-   ##
==========================================
+ Coverage   71.56%   73.76%   +2.19%     
==========================================
  Files         371      372       +1     
  Lines       37164    37248      +84     
==========================================
+ Hits        26597    27476     +879     
+ Misses      10567     9772     -795

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter
Copy link 8000
Collaborator Author
emolter commented Feb 3, 2025 •
edited
Loading

The test_custom_catalog tests are failing because I attempted to pass a custom catalog as a Path object into the schema validator instead of as a string.

I'll fix these for now, but should we consider allowing instances like these to validate successfully in the schema?

Re-running only the failing tests here: https://github.com/spacetelescope/RegressionTests/actions/runs/13122921343
all passing.

@emolter emolter marked this pull request as ready for review February 3, 2025 21:31
@emolter emolter requested review from a team as code owners February 3, 2025 21:31
@emolter emolter changed the title Modify tweakreg for code style compliance Update tweakreg for code style compliance Feb 3, 2025
@emolter emolter changed the title Update tweakreg for code style compliance Apply code style rules to tweakreg Feb 3, 2025
melanieclarke
melanieclarke reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I'll defer approval to give Brett a chance to review.

braingram
braingram reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator
@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/suggestions/bugfixes.

@emolter emolter requested a review from braingram February 5, 2025 15:08
braingram
braingram approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator
@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI and regtest rerun.

@emolter
Copy link
Collaborator Author
emolter commented Feb 5, 2025 •
edited
Loading

new regtests running here https://github.com/spacetelescope/RegressionTests/actions/runs/13160563029
re-running after I made a mistake implementing Brett's suggestions

edit: only failures are the FGS failures also on main

@emolter emolter requested a review from melanieclarke February 5, 2025 18:24
melanieclarke
melanieclarke approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@melanieclarke melanieclarke merged commit 9f84310 into spacetelescope:main Feb 5, 2025
29 of 30 checks passed
@emolter emolter deleted the JP-3860-tweakreg branch February 5, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

@melanieclarke melanieclarke melanieclarke approved these changes

Assignees
No one assigned
Labels
datamodels NIRISS no-changelog-entry-needed regression_testing testing tweakreg
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@emolter @braingram @melanieclarke
0