JP-3777: Select first and last groups in ramp fitting #9095
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9095 +/- ##
==========================================
+ Coverage 73.73% 73.75% +0.02%
==========================================
Files 373 373
Lines 37277 37298 +21
==========================================
+ Hits 27486 27509 +23
+ Misses 9791 9789 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Other than improving code coverage as @emolter suggests, it all looks good.
|
Tested and looks like this is working as expected to me; this will be a really helpful tool for instrument teams to study detector systematics in the ramps. |
…oups to be used in the fit Added a unit test and updated docs
Add test for user warnings (currently failing)
|
@stscirij - is this the regtest run for this PR? The failures look as expected for the current state on main, so I think this is ready to merge. |
|
Yes, this is the regtest run I did on Friday for this PR |
| @@ -23,10 +24,6 @@ | |||
| log.setLevel(logging.DEBUG) | |||
|
|
|||
|
|
|||
|
|
|||
| __all__ = ["RampFitStep"] | |||
There was a problem hiding this comment.
Just happened to drive by and noticed this. Why was this __all__ removed?
There was a problem hiding this comment.
Good question. I have no memory of removing it, although GitHub clearly has...
There was a problem hiding this comment.
Perhaps we should add it back. Otherwise any star import from this module will be unpredictable.
There was a problem hiding this comment.
Yes, we should put it back. Looking at the docs, I don't think removing it has done any harm, but we should have it for completeness/reliability. Could one of you please send in a PR?
There was a problem hiding this comment.
I cannot till later this afternoon. If @stscirij beats me to it, please link that PR here so we don't duplicate work. Thanks!
|
I'll do this @pllim |
|
PR is #9338 |
Added a unit test and updated docs
Resolves JP-3777
Closes #8872
This PR addresses JP-3777. It enables users to select firstgroup and lastgroup parameters when performing
ramp fitting. It works by setting the DO_NOT_USE bit in the GROUPDQ extension for groups outside the selected range.
Added a unit test and updated the docs.
Tasks
Build 11.3(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.datamodels.rstchanges/<PR#>.scripts.rstchanges/<PR#>.fits_generator.rstchanges/<PR#>.set_telescope_pointing.rstchanges/<PR#>.pipeline.rststage 1
changes/<PR#>.group_scale.rstchanges/<PR#>.dq_init.rstchanges/<PR#>.emicorr.rstchanges/<PR#>.saturation.rstchanges/<PR#>.ipc.rstchanges/<PR#>.firstframe.rstchanges/<PR#>.lastframe.rstchanges/<PR#>.reset.rstchanges/<PR#>.superbias.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.rscd.rstchanges/<PR#>.persistence.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.charge_migration.rstchanges/<PR#>.jump.rstchanges/<PR#>.clean_flicker_noise.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.gain_scale.rststage 2
changes/<PR#>.assign_wcs.rstchanges/<PR#>.badpix_selfcal.rstchanges/<PR#>.msaflagopen.rstchanges/<PR#>.nsclean.rstchanges/<PR#>.imprint.rstchanges/<PR#>.background.rstchanges/<PR#>.extract_2d.rstchanges/<PR#>.master_background.rstchanges/<PR#>.wavecorr.rstchanges/<PR#>.srctype.rstchanges/<PR#>.straylight.rstchanges/<PR#>.wfss_contam.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.fringe.rstchanges/<PR#>.pathloss.rstchanges/<PR#>.barshadow.rstchanges/<PR#>.photom.rstchanges/<PR#>.pixel_replace.rstchanges/<PR#>.resample_spec.rstchanges/<PR#>.residual_fringe.rstchanges/<PR#>.cube_build.rstchanges/<PR#>.extract_1d.rstchanges/<PR#>.resample.rststage 3
changes/<PR#>.assign_mtwcs.rstchanges/<PR#>.mrs_imatch.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.exp_to_source.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.tso_photometry.rstchanges/<PR#>.stack_refs.rstchanges/<PR#>.align_refs.rstchanges/<PR#>.klip.rstchanges/<PR#>.spectral_leak.rstchanges/<PR#>.source_catalog.rstchanges/<PR#>.combine_1d.rstchanges/<PR#>.ami.rstother
changes/<PR#>.wfs_combine.rstchanges/<PR#>.white_light.rstchanges/<PR#>.cube_skymatch.rstchanges/<PR#>.engdb_tools.rstchanges/<PR#>.guider_cds.rst