8000 Bugfix for SIRS reference pixel subtraction by drlaw1558 · Pull Request #9037 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix for SIRS reference pixel subtraction #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2024
Merged

Bugfix for SIRS reference pixel subtraction #9037

merged 3 commits into from
Dec 31, 2024

Conversation

drlaw1558
Copy link
Collaborator
@drlaw1558 drlaw1558 commented Dec 30, 2024 •
edited by melanieclarke
Loading

This PR fixes a bug with the SIRS reference pixel subtraction introduced in #8726

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure 8000 it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.fits_generator.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@drlaw1558 drlaw1558 requested a review from a team as a code owner December 30, 2024 20:26
@stscijgbot-jp stscijgbot-jp mentioned this pull request Dec 30, 2024
Closed
@codecov Codecov
Copy link
codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.90%. Comparing base (78f0647) to head (bb62f0c).
Report is 815 commits behind head on main.

Files with missing lines Patch % Lines
jwst/refpix/refpix_step.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9037   +/-   ##
=======================================
  Coverage   76.90%   76.90%           
=======================================
  Files         498      498           
  Lines       45761    45761           
=======================================
  Hits        35194    35194           
  Misses      10567    10567
Flag Coverage Δ *Carryforward flag
nightly 77.39% <ø> (ø) Carriedforward from 82c6a0f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke added this to the Build 11.2 milestone Dec 30, 2024
@melanieclarke
Copy link
Collaborator

Thanks for catching this. Regression tests are running here:
https://github.com/spacetelescope/RegressionTests/actions/runs/12551812070

@melanieclarke
Copy link
Collaborator

The regression test shows no changes at all, which was a bit surprising to me, since I know we added one explicitly to run the SIRS algorithm.

It turns out the input data for that test is NRCALONG, and the SIRS kernel file in CRDS does not have corrections for that detector. We should update the regression test as well, so that the test is nontrivial.

@drlaw1558
Copy link
Collaborator Author

Good to know; I'll have to make a note that we need to fill in the parameters for nrcalong and nrcblong too.

In the meantime we can probably replace the test to use jw01345001001_10201_00001_nrca3_uncal.fits instead; that's one of the test cases that I've been using. I've updated the test accordingly, though not sure how to update the artifacts that it'll require to be successful.

@melanieclarke
Copy link
Collaborator

Thanks for that! I'll get the artifacts in the right place and rerun the tests.

melanieclarke
melanieclarke approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the regression tests at the same link, and there were no failures, but this time I think that's right. I generated the truth files locally and checked that SIRS was actually running and made a difference to the output before uploading them.

@melanieclarke melanieclarke merged commit 933bfd2 into spacetelescope:main Dec 31, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melanieclarke melanieclarke melanieclarke approved these changes

Assignees
No one assigned
Labels
NIRCAM refpix regression_testing
Projects
None yet
Milestone
Build 11.2
Development

Successfully merging this pull request may close these issues.
2 participants
@drlaw1558 @melanieclarke
0