-
Notifications
You must be signed in to change notification settings - Fork 174
JP-3753: Refactor extract1d #8961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
20ff9ac
Start extract1d refactor
melanieclarke fffc5a3
Add test for custom extraction with polynomial limits
melanieclarke 008ab50
Fix log message f-string
melanieclarke 90be511
Deduplicate extraction interface
melanieclarke 40e7c1e
Remove image reference type
melanieclarke a43bcef
Separate IFU from slit extraction
melanieclarke dd7ae7f
Remove NIRISS SOSS references from slit extraction code
melanieclarke fa073c3
Remove unnecessary middleman function; condense input type checking
melanieclarke 28cdba4
Add helper functions for special extraction modes
melanieclarke 287097e
Clean up messages
melanieclarke 3d4cb24
First version incorporating new extraction engine
melanieclarke c992641
Fix extraction limit defaults and partial pixel weights
melanieclarke 1690a2a
Npixels is sum of weights instead of sum of pixels with non-zero weight
melanieclarke a1c3670
Move profile and wavelength calculations out of integration loop
melanieclarke 6a7e9eb
Tidying up
melanieclarke ca09589
Update unit tests for new extract1d
melanieclarke c7aec5d
Add left/right limit handling, fix partial pixel weights
melanieclarke cea2a60
Make polynomial coefficient definition backward compatible
melanieclarke 2d80f63
Clean up aperture definition, fix edge cases
melanieclarke dffea4c
Coverage tests for step interface
melanieclarke e4517e8
Move aperture correction setup outside integration loop
melanieclarke d03d049
Return separate values from locn_from_wcs function
melanieclarke aef5fc4
Rename 'boxcar' extraction to 'box'
melanieclarke 91c6bbd
Set up for future optimal extraction
melanieclarke 49dad52
Tidy up code organization, add docstrings
melanieclarke 485000f
Code style fixes
melanieclarke 75c8722
Make sure background values are finite: they default to 0, not NaN
melanieclarke 6d31859
More general check for unresampled nirspec data
melanieclarke f95ce81
More robust file saving for containers
melanieclarke a4db010
Add option to save spatial profile
melanieclarke 9d92181
Add check for negative values in profile
melanieclarke 69a5d0f
Add option to save scene model
melanieclarke 5f42f84
Fix scene model default
melanieclarke f8388e4
Minor fixes for optimal extraction support
melanieclarke 22faef6
Add check for missing variances
melanieclarke 20fb4cb
Adding unit tests for extraction
melanieclarke 687d14d
Add temporary fix for background fit test
melanieclarke 0ed0d96
Coverage tests for extract1d
melanieclarke e47e853
Better npixels estimate for optimal extraction; fix background fit test
melanieclarke f71317d
More unit tests for extract_1d coverage
melanieclarke 73f3649
Fix npixels for non-uniform weights
melanieclarke 49b9e50
More coverage tests
melanieclarke 82615f4
More unit tests for extract
melanieclarke 74e2e6e
Tests for extract_one_slit
melanieclarke b660e81
Add change log fragment
melanieclarke 4eb52d6
Make some parameters for create_extraction keywords instead of args
melanieclarke ec1c53c
Test coverage for create_extraction and run_extract1d
melanieclarke ee6ebc7
Reformat change note
melanieclarke 7a68e62
Update docs for extract1d
melanieclarke a847dde
Add more API docs for extraction tools
melanieclarke 55c5fd3
Make change notes fit on one line
melanieclarke 83f27fd
Minor docs clarifications
melanieclarke 40e94d7
Fixes and clarifications from PR review
melanieclarke 6752d31
Refactor extract1d with helper functions for extraction cases
melanieclarke f24f9ea
Clarify partial pixel weights; check for finite wavelengths
melanieclarke 61628fe
Fix wavelength check; revise aperture center
melanieclarke b6cd760
Don't override explicit user setting for use_source_posn
melanieclarke 5d60520
Add guardrails for smoothing length
melanieclarke 2144996
Add note about use_source_posn for extended sources
melanieclarke 0a3dfad
Fix typo
melanieclarke 67bef53
Reduce repeated code for copying keywords
melanieclarke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Refactor the core extraction algorithm and aperture definition modules for slit and slitless extractions, for greater efficiency and maintainability. Extraction reference files in FITS format are no longer supported. Current behavior for extractions proceeding from extract1d reference files in JSON format is preserved, with minor improvements: DQ arrays are populated and error propagation is improved for some aperture types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguments are reordered, with new section headings, to make it clearer which parameters work for which exposure types.