8000 JP-2928: Update regression test data for NIRCam subarray by melanieclarke · Pull Request #8881 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2928: Update regression test data for NIRCam subarray #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2024
Merged

JP-2928: Update regression test data for NIRCam subarray #8881

merged 2 commits into from
Oct 22, 2024

Conversation

melanieclarke
Copy link
Collaborator
@melanieclarke melanieclarke commented Oct 11, 2024 •
edited
Loading

Partially addresses JP-2928

Update regression test data for NIRCam subarray, reference pixel correction test.

The new data is from PID 1409, obs 34, chosen for its similarity to the original data product (subarray subgrism64, exp_type nrc_tsimage, ngroups 5, nints 1).

The new data is from PID 2459, obs 5: EXP_TYPE=NRC_TSIMAGE, SUBARRAY=SUBGRISM64, NINTS=4, NGROUPS=5, NOUTPUTS=4.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the tr 8000 uth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.fits_generator.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@melanieclarke melanieclarke added this to the Build 11.2 milestone Oct 11, 2024
@melanieclarke
Copy link
Collaborator Author
melanieclarke commented Oct 11, 2024 •
edited
Loading

Regression tests here, with locally generated truth files:
https://github.com/spacetelescope/RegressionTests/actions/runs/11296621434

Test failures are unrelated.

@stscijgbot-jp stscijgbot-jp mentioned this pull request Oct 11, 2024
Closed
@codecov Codecov
Copy link
codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.85%. Comparing base (58429ee) to head (19f7809).
Report is 457 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8881      +/-   ##
==========================================
+ Coverage   61.83%   61.85%   +0.01%     
==========================================
  Files         377      377              
  Lines       38896    38877      -19     
==========================================
- Hits        24050    24046       -4     
+ Misses      14846    14831      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke melanieclarke force-pushed the jp-2928-nircam-subarray branch from d735799 to 338717f Compare October 14, 2024 21:11
@melanieclarke melanieclarke marked this pull request as ready for review October 14, 2024 21:13
@melanieclarke melanieclarke requested a review from a team as a code owner October 14, 2024 21:13
@stscirij
Copy link
Contributor

Looks like the chosen dataset only reads through 1 amp (NOUTPUTS=1), whereas the original used 4 and the title of the test implies that a 4 amp readout is desired?

@melanieclarke
Copy link
Collaborator Author

Looks like the chosen dataset only reads through 1 amp (NOUTPUTS=1), whereas the original used 4 and the title of the test implies that a 4 amp readout is desired?

Ah, thank you! I missed that. I'll look for another data set.

@melanieclarke melanieclarke force-pushed the jp-2928-nircam-subarray branch from 1043574 to 595c9c1 Compare October 21, 2024 18:13
@melanieclarke
Copy link
Collaborator Author
melanieclarke commented Oct 21, 2024 •
edited
Loading

Re-running regtests here with the new data set that has NOUTPUTS=4:
https://github.com/spacetelescope/RegressionTests/actions/runs/11446241421

Results look good; the 2 remaining failures are unrelated.

@melanieclarke melanieclarke force-pushed the jp-2928-nircam-subarray branch from 595c9c1 to 19f7809 Compare October 21, 2024 18:29
@melanieclarke
Copy link
Collaborator Author

@stscirij - I think this is ready for re-review.

stscirij
stscirij approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor
@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@melanieclarke melanieclarke merged commit 704ac9d into spacetelescope:main Oct 22, 2024
31 checks passed
@melanieclarke melanieclarke deleted the jp-2928-nircam-subarray branch October 22, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscirij stscirij stscirij approved these changes

Assignees
No one assigned
Labels
NIRCAM no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
Build 11.2
Development

Successfully merging this pull request may close these issues.
2 participants
@melanieclarke @stscirij
0