10000 Update coron tests for numpy 2 compatibility by melanieclarke · Pull Request #8812 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update coron tests for numpy 2 compatibility #8812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2024
Merged

Update coron tests for numpy 2 compatibility #8812

merged 3 commits into from
Sep 20, 2024

Conversation

melanieclarke
Copy link
Collaborator
@melanieclarke melanieclarke commented Sep 20, 2024 •
edited
Loading

Closes #8579

Update coron registration unit tests for numpy 2 precision differences

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is re 10000 solved properly

@codecov Codecov
Copy link
codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.81%. Comparing base (7683808) to head (b07e8fc).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8812   +/-   ##
=======================================
  Coverage   61.81%   61.81%           
=======================================
  Files         377      377           
  Lines       38915    38915           
=======================================
  Hits        24056    24056           
  Misses      14859    14859

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke melanieclarke marked this pull request as ready for review September 20, 2024 18:08
@melanieclarke melanieclarke requested a review from a team as a code owner September 20, 2024 18:08
tapastro
tapastro approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor
@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tapastro tapastro merged commit 0f42916 into spacetelescope:master Sep 20, 2024
17 of 18 checks passed
@melanieclarke melanieclarke deleted the coron_unit_tests branch September 20, 2024 18:13
@melanieclarke melanieclarke added this to the Build 11.1 milestone Sep 20, 2024
@melanieclarke melanieclarke mentioned this pull request Sep 20, 2024
Merged
8 tasks
@melanieclarke melanieclarke mentioned this pull request Sep 30, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro tapastro approved these changes

Assignees
No one assigned
Labels
coron3 pipeline no-changelog-entry-needed testing
Projects
None yet
Milestone
Build 11.1
Development

Successfully merging this pull request may close these issues.

test_coron failures with numpy 2.0
2 participants
@melanieclarke @tapastro
0