JP-3547: Fix MIRI array sizing for multiple inputs and pixel ratio != 1 #8727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regression tests here: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8727 +/- ##
=======================================
Coverage 60.55% 60.55%
=======================================
Files 372 372
Lines 38371 38371
=======================================
Hits 23235 23235
Misses 15136 15136 ☔ View full report in Codecov by Sentry. |
|
Regtest failures all look unrelated - there are no changes to any spectral resampling products. |
emolter
approved these changes
Aug 27, 2024
|
LG2M: Fixes the issue with LRS slit data, and results look as expected in a test case of spec3-combined dithered data. |
|
@tapastro - can you please review for the maintainers? |
tapastro
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3547
Fixes an issue discovered during testing for #8596.
For MIRI, when there are multiple input files and pixel_scale_ratio is set to something other than 1.0, the output array size was being computed incorrectly: the pixel_scale_ratio was applied twice. This PR fixes that issue and adds a unit test for the multiple input case.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rstwithin the relevant release sectionupdated relevant documentationHow to run regression tests on a PR