update test to allow easier deprecation of ignore_version_mismatch
#8693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore_version_mismatch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8693 +/- ##
=======================================
Coverage 60.38% 60.38%
=======================================
Files 372 372
Lines 38337 38337
=======================================
Hits 23148 23148
Misses 15189 15189 ☔ View full report in Codecov by Sentry. |
5 tasks
tapastro
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a filter to ignore a deprecation warning for an upcoming asdf deprecation:
asdf-format/asdf#1819
ignore_version_mismatchhas done nothing since asdf 3.0.0. However it is currently set in stdatamodels:spacetelescope/stdatamodels#313
Deprecating the feature in asdf will cause 1 jwst test to fail which turns all warnings into errors:
jwst/jwst/assign_wcs/tests/test_schemas.py
Line 57 in 89f126a
This PR ignores the upcoming deprecation warning to allow the test to continue to pass. The trigger for the warning is being addressed in the above stdatamodels PR but would otherwise require a new stdatamodels release (with the above PR). Filtering this warning seems like an easier option.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR