JP-3639: Implement 1/f noise correction for ramp data #8669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8669 +/- ##
==========================================
+ Coverage 60.75% 61.74% +0.99%
==========================================
Files 375 377 +2
Lines 38367 38716 +349
==========================================
+ Hits 23308 23904 +596
+ Misses 15059 14812 -247 ☔ View full report in Codecov by Sentry. |
|
This is ready for initial reviews. There is one change outstanding for the NSClean implementation (#8745), which needs to merge first, but I'd like to get the rest of the code reviewed for software issues. I'll run regression tests after the NSClean change is done, unless it would be helpful to see them now. |
kmacdonald-stsci
approved these changes
Sep 10, 2024
8 tasks
|
Regression tests started here: |
|
In the regression test results:
|
10 tasks
hayescr
reviewed
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3639
Closes #8517
Add a flicker noise correction step to the detector1 pipeline.
Implements both a median-based correction, based on Chris Willott's image1overf, and an fft-based algorithm, based on Bernard Rauscher's NSClean. The
nscleanstep in spec2 is now aliased to the clean_flicker_noise step, which can support either rate-like input or ramp-like input.Various scene masking options are provided for either correction option. When run from detector1, the ramp_fit step is run to generate a temporary rate image, used to generate the scene mask. For NIRSpec spectral data, if mask_science_regions is True, the assign_wcs and msaflagopen steps are additionally run to allow masking of the entire science area. For MIRI imaging data, if mask_science_regions is True, the flat_field step is run to retrieve NON_SCIENCE flags, used to block light from the metering structure.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR