10000 JP-3617: Add check for uncalibrated filters for NIRISS SOSS by melanieclarke · Pull Request #8549 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3617: Add check for uncalibrated filters for NIRISS SOSS #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2024
Merged

JP-3617: Add check for uncalibrated filters for NIRISS SOSS #8549

merged 3 commits into from
Jun 14, 2024

Conversation

melanieclarke
Copy link
Collaborator
@melanieclarke melanieclarke commented Jun 11, 2024 •
edited by hbushouse
Loading

Resolves JP-3617

Closes #8472

Update to TSO stage 2b and 3 association rules to skip processing for an uncalibrated filter for NIRISS SOSS.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@melanieclarke melanieclarke added this to the Build 11.0 milestone Jun 11, 2024
@codecov Codecov
Copy link
codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.54%. Comparing base (93574c3) to head (aab5816).
Report is 331 commits behind head on master.

Files with missing lines Patch % Lines
jwst/associations/lib/dms_base.py 70.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8549      +/-   ##
==========================================
- Coverage   58.61%   58.54%   -0.07%     
==========================================
  Files         391      388       -3     
  Lines       39066    38972      -94     
==========================================
- Hits        22897    22818      -79     
+ Misses      16169    16154      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Collaborator Author

Regression tests started here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1516/

@stscijgbot-jp stscijgbot-jp mentioned this pull request Jun 11, 2024
Closed
@melanieclarke
Copy link
Collaborator Author

In the regression test results, test_against_standard[jw03596_20240314t012345_pool] is the change I was expecting: this pool contains a NIRISS SOSS F277W observation that no longer produces association files.

The others are related to #8537.

@melanieclarke melanieclarke marked this pull request as ready for review June 12, 2024 13:11
@melanieclarke melanieclarke requested a review from a team as a code owner June 12, 2024 13:11
hbushouse
hbushouse approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit a818479 into spacetelescope:master Jun 14, 2024
28 checks passed
@melanieclarke melanieclarke changed the title Add check for uncalibrated filters for NIRISS SOSS JP-3617: Add check for uncalibrated filters for NIRISS SOSS Jun 14, 2024
@melanieclarke melanieclarke deleted the jp-3617 branch June 14, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
associations NIRISS SOSS
Projects
None yet
Milestone
Build 11.0
Development

Successfully merging this pull request may close these issues.

Update ASN rules to exclude NIRISS SOSS F277W exposures
2 participants
@melanieclarke @hbushouse
0