JP-3629: Add new non-header keywords in local pool generator #8508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8508 +/- ##
=======================================
Coverage 57.97% 57.98%
=======================================
Files 387 388 +1
Lines 38830 38918 +88
=======================================
+ Hits 22513 22566 +53
- Misses 16317 16352 +35 ☔ View full report in Codecov by Sentry. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I don't see any button to dismiss my review, which was supposed to be related to a different PR entirely, sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3629
Closes #8495
This PR fixes a minor issue with the asn_make_pool script, causing it to skip making spec2 files for all NIRSpec IFU data. It needed a couple new non-header keywords added to its default values.
Regression tests shouldn't need to be run for this change: it is a change to a convenience script only.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rstwithin the relevant release sectionupdated relevant documentationran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR