bump stcal to recent 1.7.1 release
#8505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM.
I'm not sure if this needs regtests as the ones last night used 1.7.1:
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST/detail/JWST/2898/pipeline/184#step-194-log-91
as did the latest CI run on main:
https://github.com/spacetelescope/jwst/actions/runs/9209518035/job/25334329508#step:10:95
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8505 +/- ##
==========================================
+ Coverage 57.93% 57.97% +0.04%
==========================================
Files 387 387
Lines 38839 38830 -9
==========================================
+ Hits 22502 22513 +11
+ Misses 16337 16317 -20 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumps
stcalto1.7.1to use new ramp fit parameterChecklist for PR authors (skip items if you don't have permissions or they are not applicable)
added entry inCHANGES.rstwithin the relevant release sectionupdated or added relevant testsupdated relevant documentationHow to run regression tests on a PR
Make sure the JIRA ticket is resolved properly