8000 JP-3612: Fix MOS background slit source position by melanieclarke · Pull Request #8461 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3612: Fix MOS background slit source position #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2024
Merged

JP-3612: Fix MOS background slit source position #8461

merged 3 commits into from
May 8, 2024

Conversation

melanieclarke
Copy link
Collaborator
@melanieclarke melanieclarke commented May 6, 2024 •
edited by hbushouse
Loading

Resolves JP-3612

Closes #8459

This PR moves the assigned source position for dedicated MOS background slits from the lower left corner of the slit to the middle of the slit.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@melanieclarke melanieclarke requested a review from a team as a code owner May 6, 2024 16:01
@melanieclarke
Copy link
Collaborator Author

Regression tests started here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1418/

@codecov Codecov
Copy link
codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (6580914) to head (6cdeb46).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8461      +/-   ##
==========================================
+ Coverage   56.38%   56.54%   +0.16%     
==========================================
  Files         387      387              
  Lines       38716    38785      +69     
==========================================
+ Hits        21830    21932     +102     
+ Misses      16886    16853      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke melanieclarke force-pushed the mos_bg_source_position branch from c2ef8a4 to 8bdd389 Compare May 6, 2024 17:26
@melanieclarke
Copy link
Collaborator Author

Regression test changes are only in the SRCXPOS and SRYPOS keywords, and in the PATHLOSS_PS extension in intermediate files, as expected. PATHLOSS_PS is now all 1.0, as expected for a centered source.

@melanieclarke melanieclarke force-pushed the mos_bg_source_position branch from 8bdd389 to f590c06 Compare May 6, 2024 21:34
@melanieclarke melanieclarke added this to the Build 11.0 milestone May 7, 2024
@hbushouse hbushouse requested a review from nden May 7, 2024 19:16
nden
nden approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator
@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@nden nden merged commit c9e8275 into spacetelescope:master May 8, 2024
27 of 28 checks passed
@stscijgbot-jp stscijgbot-jp mentioned this pull request May 8, 2024
Closed
@melanieclarke melanieclarke deleted the mos_bg_source_position branch May 8, 2024 15:57
@melanieclarke melanieclarke mentioned this pull request May 8, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

Assignees
No one assigned
Labels
assign_wcs NIRSPEC MSA NIRSPEC testing
Projects
None yet
Milestone
Build 11.0
Development

Successfully merging this pull request may close these issues.

MOS background sources are assigned lower left source position
3 participants
@melanieclarke @nden @hbushouse
0