10000 allow ami_analyze step to run on cal files by braingram · Pull Request #8451 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

allow ami_analyze step to run on cal files #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2024
Merged

allow ami_analyze step to run on cal files #8451

merged 2 commits into from
May 7, 2024

Conversation

braingram
Copy link
Collaborator
@braingram braingram commented Apr 30, 2024 •
edited by hbushouse
Loading

This allows ami_analyze to run on cal files. A regression test is added (input and truth files will be added and a run started when the files are approved).

This is an alternative to #8448 and instead of using the generic DataModel converts the input ImageModel to a CubeModel before the dimension expansion.

Regression tests run at:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1411/
Showed 1 unrelated error in [stable-deps] test_filter_rotation – jwst.assign_wcs.tests.test_niriss which is also failing on main:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST/2869/testReport/junit/jwst.assign_wcs.tests/test_niriss/_stable_deps__test_filter_rotation/
The regtest added in this PR passed.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram mentioned this pull request Apr 30, 2024
Closed
7 tasks
@codecov Codecov
Copy link
codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.45%. Comparing base (6580914) to head (4fdc145).
Report is 6 commits behind head on master.

Files Patch % Lines
jwst/ami/ami_analyze.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8451      +/-   ##
==========================================
+ Coverage   56.38%   56.45%   +0.07%     
==========================================
  Files         387      387              
  Lines       38716    38774      +58     
==========================================
+ Hits        21830    21891      +61     
+ Misses      16886    16883       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review April 30, 2024 14:34
@braingram braingram requested a review from a team as a code owner April 30, 2024 14:34
@braingram braingram requested review from rcooper295 and removed request for a team April 30, 2024 14:34
rcooper295
rcooper295 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor
@rcooper295 rcooper295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification looks good, I examined the outputs of the new regtest for 2D files and didn't notice anything obviously amiss. Thanks for doing this!

@braingram braingram requested a review from hbushouse April 30, 2024 16:41
@braingram braingram force-pushed the ami_cal branch 2 times, most recently from 4e1c9d0 to aa7d858 Compare May 2, 2024 15:25
@hbushouse hbushouse added this to the Build 11.0 milestone May 7, 2024
hbushouse
hbushouse approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 080d785 into spacetelescope:master May 7, 2024
26 of 28 checks passed
@braingram braingram deleted the ami_cal branch May 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@rcooper295 rcooper295 rcooper295 approved these changes

Assignees
No one assigned
Labels
ami ami3 pipeline NIRISS 4BB1 regression_testing
Projects
None yet
Milestone
Build 11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@braingram @hbushouse @rcooper295
0