8000 JP-3463: Add log message to dark step by drlaw1558 · Pull Request #8425 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3463: Add log message to dark step #8425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

JP-3463: Add log message to dark step #8425

merged 2 commits into from
Apr 23, 2024

Conversation

drlaw1558
Copy link
Collaborator
@drlaw1558 drlaw1558 commented Apr 16, 2024 •
edited by hbushouse
Loading

This PR addresses JP-3463, adding a message to the log.info when users specify a value for average_dark_current to make clear that the value is being used.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@drlaw1558 drlaw1558 requested a review from a team as a code owner April 16, 2024 21:49
@codecov Codecov
Copy link
codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.30%. Comparing base (2fb073e) to head (043c4a8).
Report is 34 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8425       +/-   ##
===========================================
- Coverage   75.31%   56.30%   -19.02%     
===========================================
  Files         474      390       -84     
  Lines       38965    38886       -79     
===========================================
- Hits        29345    21893     -7452     
- Misses       9620    16993     +7373
Flag Coverage Δ
nightly ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stscijgbot-jp stscijgbot-jp mentioned this pull request Apr 16, 2024
Closed
@hbushouse hbushouse added this to the Build 11.0 milestone Apr 23, 2024
hbushouse
hbushouse approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hbushouse hbushouse merged commit 13e0927 into spacetelescope:master Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
dark_current
Projects
None yet
Milestone
Build 11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@drlaw1558 @hbushouse
0