8000 Remove upper pytest pin, switch globals use to fixture in stpipe test by braingram · Pull Request #8347 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove upper pytest pin, switch globals use to fixture in stpipe test #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2024
Merged

Remove upper pytest pin, switch globals use to fixture in stpipe test #8347

merged 1 commit into from
Mar 16, 2024

Conversation

braingram
Copy link
Collaborator

The pytest pin added in:
#8328
can be removed as pytest-doctestplus now supports pytest==8.1.1

The automated PR that attempted this bump:
#8346
showed a new failure in one unit test:

FAILED jwst/stpipe/tests/test_crds.py::test_crds_step_override - ValueError: Empty filename: None

This PR updates the test to use a fixture instead of global variables to allow it to pass.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram mentioned this pull request Mar 12, 2024
Closed
@braingram braingram marked this pull request as ready for review March 12, 2024 11:19
@braingram braingram requested a review from a team as a code owner March 12, 2024 11:19
@codecov Codecov
Copy link
codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.31%. Comparing base (4cc0ac1) to head (2fb073e).
Report is 29 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8347      +/-   ##
==========================================
+ Coverage   75.15%   75.31%   +0.15%     
==========================================
  Files         470      474       +4     
  Lines       38604    38965     +361     
==========================================
+ Hits        29014    29345     +331     
- Misses       9590     9620      +30
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.06%) ⬇️ Carriedforward from 4cc0ac1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zacharyburnett
zacharyburnett approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator
@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep an eye out for this in other repos too, it's probably copy / pasted somewhere

@braingram
Copy link
Collaborator Author
braingram commented Mar 13, 2024 •
edited
Loading

Regtests ran at:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1303/
21 failures (much like the 24 failures on the latest main run) similar to:

     Headers contain differences:
       Keyword BUNIT    has different values:
          a> MJy
          b> DN/s

likely from out-of-date truth files post merge of #8294
Given that this PR updates pytest (a minor improvement) and required test change I'd say we wait for a clean regtest run.

@braingram
Copy link
Collaborator Author
braingram commented Mar 16, 2024 •
edited
Loading

Another regtest run started: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1323/
This one only shows 1 error which matches the error seen on main:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST/2812/testReport/jwst.regtest/test_nircam_image/_stable_deps__test_image3_closedfile/

@braingram braingram merged commit 7ddcbc7 into spacetelescope:master Mar 16, 2024
@braingram braingram deleted the remove_pytest_pin branch March 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
installation no-changelog-entry-needed stpipe testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @zacharyburnett
0