8000 JP-3150: skip extract1d for NIRISS SOSS data in F277W filter by emolter · Pull Request #8275 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3150: skip extract1d for NIRISS SOSS data in F277W filter #8275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2024
Merged

JP-3150: skip extract1d for NIRISS SOSS data in F277W filter #8275

merged 5 commits into from
Apr 11, 2024

Conversation

emolter
Copy link
Collaborator
@emolter emolter commented Feb 14, 2024 •
edited by hbushouse
Loading

Resolves JP-3150

Closes #7842

This PR addresses error aborts when extract_1d is called on SOSS data in the F277W filter. With this change, the extract_1d step and subsequent photom step are now skipped instead.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov Codecov
Copy link
codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (2fb073e) to head (24707f6).
Report is 27 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8275      +/-   ##
==========================================
+ Coverage   75.31%   75.79%   +0.48%     
==========================================
  Files         474      476       +2     
  Lines       38965    39448     +483     
==========================================
+ Hits        29345    29899     +554     
+ Misses       9620     9549      -71
Flag Coverage Δ *Carryforward flag
nightly 77.67% <ø> (+0.33%) ⬆️ Carriedforward from 3153fbc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review March 28, 2024 13:31
@emolter emolter requested a review from a team as a code owner March 28, 2024 13:31
@hbushouse hbushouse added this to the Build 11.0 milestone Apr 5, 2024
@hbushouse
Copy link
Collaborator

@emolter Has there been a regtest run for this?

@emolter
Copy link
Collaborator Author
emolter commented Apr 5, 2024

starting run here.

hbushouse
hbushouse approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Regtests are passing.

@hbushouse hbushouse merged commit bc3274a into spacetelescope:master Apr 11, 2024
@stscijgbot-jp stscijgbot-jp mentioned this pull request Apr 11, 2024
Closed
@emolter emolter deleted the JP-3150 branch April 11, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
extract_1d NIRISS SOSS testing
Projects
None yet
Milestone
Build 11.0
Development

Successfully merging this pull request may close these issues.

Error abort in extract_1d for NIRISS SOSS with F277W
2 participants
@emolter @hbushouse
0