remove unused test data files #8266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8266 +/- ##
=======================================
Coverage 75.19% 75.19%
=======================================
Files 470 470
Lines 38580 38580
=======================================
Hits 29012 29012
Misses 9568 9568
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hbushouse
approved these changes
Feb 8, 2024
Thanks for taking a look! You're spot on. I updated the PR description to mention this and link where the files are used (non_standard_primary_array.schema.json is the only file that appears entirely unused). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a few unused test data files in the
jwst/datamodels/tests/datadirectory.The files removed are all duplicates of files now in
stdatamodelshttps://github.com/spacetelescope/stdatamodels/tree/main/tests/data
which also contains the tests that use (all but one of) these files:
nonstandard_primary_array.schema.json appears to be entirely unused.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR