8000 JP-2259: Tweakreg source finding by emolter · Pull Request #8203 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2259: Tweakreg source finding #8203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 23, 2024
Merged

JP-2259: Tweakreg source finding #8203

merged 13 commits into from
Jan 23, 2024

Conversation

emolter
Copy link
Collaborator
@emolter emolter commented Jan 17, 2024 •
edited by hbushouse
Loading

Resolves JP-2259

Closes #6295

This PR addresses inadequate star finding results during the tweakreg step for data with undersampled PSFs, e.g. short-wavelength NIRISS imaging data. This PR allows the user to choose between three star finding algorithms, and exposes the keyword arguments to each.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Jenkins job

@codecov Codecov
Copy link
codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (b2fd704) 75.25% compared to head (1bedfc8) 74.89%.
Report is 2 commits behind head on master.

❗ Current head 1bedfc8 differs from pull request most recent head 230989e. Consider uploading reports for the commit 230989e to get more accurate results

Files Patch % Lines
jwst/tweakreg/tweakreg_catalog.py 22.91% 37 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8203      +/-   ##
==========================================
- Coverage   75.25%   74.89%   -0.36%     
==========================================
  Files         470      470              
  Lines       38470    38693     +223     
==========================================
+ Hits        28950    28979      +29     
- Misses       9520     9714     +194
Flag Coverage Δ *Carryforward flag
nightly 77.36% <ø> (-0.01%) ⬇️ Carriedforward from 392e5cb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review January 18, 2024 23:27
@emolter emolter requested a review from a team as a code owner January 18, 2024 23:27
@hbushouse hbushouse changed the title Tweakreg source finding JP-2259: Tweakreg source finding Jan 22, 2024
@hbushouse hbushouse added this to the Build 10.2 milestone Jan 22, 2024
hbushouse
hbushouse reviewed Jan 22, 2024
View reviewed changes
@hbushouse
Copy link
Collaborator

Failures in the 2 CI tests that are not codecov related could be due to sporadic hiccups with connection to CRDS. Triggering CI tests again may get a clean run.

@hbushouse
Copy link
Collaborator

The 1 remaining CI test that fails is due to incompatibility of photutils methods in the oldest dependency versions. Not a concern.

@hbushouse hbushouse merged commit cf7400b into spacetelescope:master Jan 23, 2024
@stscijgbot-jp stscijgbot-jp mentioned this pull request Jan 23, 2024
Closed
@braingram braingram mentioned this pull request Jan 23, 2024
Merged
7 tasks
emolter added a commit to emolter/jwst that referenced this pull request Jan 23, 2024
@emolter
JP-2259: small fix to PR spacetelescope#8203 to cover oldest dependen…
8c94091 
…cies failure
@jdavies-st jdavies-st mentioned this pull request Feb 26, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
documentation NIRCAM NIRISS regression_testing testing tweakreg
Projects
None yet
Milestone
Build 10.2
Development

Successfully merging this pull request may close these issues.

Source finding algorithm in tweakreg_catalog is inadequate
2 participants
@emolter @hbushouse
0