JP-2385: Changed logic in validation of grism bounding boxes #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapastro
commented
Jan 18, 2022
jwst/assign_wcs/util.py
Outdated
| @@ -769,7 +769,7 @@ def _create_grism_bbox(input_model, mmag_extract=99.0, | |||
| pts = np.array([[ymin, xmin], [ymax, xmax]]) | |||
| ll = np.array([0, 0]) | |||
| ur = np.array([input_model.meta.subarray.ysize, input_model.meta.subarray.xsize]) | |||
| inidx = np.all(np.logical_and(ll <= pts, pts <= ur), axis=1) | |||
| inidx = np.all(np.logical_and(ll < pts, pts < (ur-1)), axis=1) | |||
There was a problem hiding this comment.
Reviewers: still not convinced I have this 100% correct - the goal being to disallow bboxes with width 1 on either edge. If xmin and xmax are both 0 or 2047 (in the case of xsize=2048), does this do what I'd like?
Codecov Report
@@ Coverage Diff @@
## master #6579 +/- ##
==========================================
- Coverage 74.56% 73.30% -1.27%
==========================================
Files 413 413
Lines 36686 37516 +830
==========================================
+ Hits 27356 27500 +144
- Misses 9330 10016 +686
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
reviewed
Jan 19, 2022
…; lower logging statements to DEBUG after verbosity removal
hbushouse
approved these changes
Jan 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6576
Resolves JP-2385
Description
This PR addresses 1-width spectra being fed to combine_1d from NRC_WFSS data. The issue was found to be in validation of the grism bounding boxes, where 1-width extractions were being allowed. The logic was missing for both edges of the detector (i.e., xmin & xmax are both either 0 or 2047), and has now been added.
This PR also includes a somewhat-unrelated clean-up of extract_1d to remove a verbose flag getting thrown around but not accessible to users.
Checklist