8000 JP-2348: Fix PATTTYPE enum values by hbushouse · Pull Request #6501 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2348: Fix PATTTYPE enum values #6501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2021
Merged

JP-2348: Fix PATTTYPE enum values #6501

merged 2 commits into from
Dec 10, 2021

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Dec 9, 2021 •
edited
Loading

Closes #6500
Resolves JP-2348

Description

This PR updates several values in the core schema PATTTYPE enum list to change underscores to hyphens and capitalize "NIRCAM", to match the current list of values in the Keyword Dictionary.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@hbushouse hbushouse added datamodels keywords Anything related to FITS header keywords labels Dec 9, 2021
@hbushouse hbushouse added this to the Build 7.9 milestone Dec 9, 2021
@codecov
Copy link
codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #6501 (aa80c93) into master (5e5a844) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6501   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         409      409           
  Lines       34848    34848           
=======================================
  Hits        27380    27380           
  Misses       7468     7468
Flag Coverage Δ *Carryforward flag
nightly 78.55% <ø> (ø) Carriedforward from 6132d23
unit 55.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5a844...aa80c93. Read the comment docs.

tapastro
tapastro approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor
@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit f160114 into spacetelescope:master Dec 10, 2021
@hbushouse hbushouse deleted the jp2348 branch December 10, 2021 15:54
@stscijgbot-jp stscijgbot-jp mentioned this pull request Dec 10, 2021
Closed
stscieisenhamer pushed a commit to stscieisenhamer/jwst that referenced this pull request Jan 7, 2022
@hbushouse @stscieisenhamer
JP-2348: Fix PATTTYPE enum values (spacetelescope#6501)
dfa0016 
* JP-2348: Fix PATTTYPE enum values

* add change log entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro tapastro approved these changes

@stscieisenhamer stscieisenhamer Awaiting requested review from stscieisenhamer

Assignees
No one assigned
Labels
datamodels keywords Anything related to FITS header keywords
Projects
None yet
Milestone
Build 7.9
Development

Successfully merging this pull request may close these issues.

Update PATTTYPE enum lists to match Keyword Dictionary
2 participants
@hbushouse @tapastro
0