JP-2347: Fix names of SOSS extraction keywords #6499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6499 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 409 409
Lines 34848 34848
=======================================
Hits 27380 27380
Misses 7468 7468
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
stscieisenhamer
pushed a commit
to stscieisenhamer/jwst
that referenced
this pull request
Jan 7, 2022
* JP-2347: Fix names of SOSS extraction keywords * update change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6498
Resolves JP-2347
Description
This PR fixes the names of several keywords related to the new NIRISS SOSS extract_1d operation. The old names were longer than 8 characters and hence illegal.
Checklist