JP-2153: Enable spectral order as input to WCS in NIRIS SOSS mode. #6496
Conversation
7c5d458 to
9db606f
Compare
|
The CompoundBoundingBox changes are relased now in |
9db606f to
a949555
Compare
Codecov Report
@@ Coverage Diff @@
## master #6496 +/- ##
===========================
8000
===============
- Coverage 78.33% 78.24% -0.09%
==========================================
Files 405 405
Lines 34620 34737 +117
==========================================
+ Hits 27119 27180 +61
- Misses 7501 7557 +56
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
jwst/assign_wcs/niriss.py
Outdated
| elif order == 2: | ||
| return (tuple(2 * bbox_y), tuple(2 * bbox_x)) | ||
| elif order == 3: | ||
| return (tuple(3 * bbox_y), tuple(3 * bbox_x)) |
There was a problem hiding this comment.
Currently all orders have the same bbox, defined correctly under order=1. In the future we may want to change this but for now we'll use the entire subarray.
There was a problem hiding this comment.
See changes in 444742a.
|
Needs a change log. |
a949555 to
6c3c413
Compare
…pacetelescope#6496) * Initial changes to enable complex bounding_box use * Removed some prints * Moved CompoundBoundingBox to gwcs * Changes to enable compound bounding box for niriss * Enabled order support for compound bounding box * Added changelog and addressed review comments.
Resolves JP-2153
Description
This uses the new astropy compound bounding box in order to enable usage of spectral order as a direct input to the wcs in NIRIS SOSS mode.
Note this PR requires the changes from #6205 (so that it passes with the recent changes to gwcs) and spacetelescope/gwcs#375 (to enable the use of compound bounding boxes in gwcs).
Checklist