JP-2331 Cube build footprint #6478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drlaw1558
approved these changes
Nov 29, 2021
jwst/cube_build/ifu_cube.py
Outdated
| @@ -1227,6 +1227,17 @@ def setup_ifucube_wcs(self): | |||
| world = False | |||
| if self.coord_system == 'skyalign': | |||
| world = True | |||
| # Do not use the spatial or spectral region found wcs if | |||
There was a problem hiding this comment.
Suggest:
Do not use the default spatial or spectral region found in the wcs if
Codecov Report
@@ Coverage Diff @@
## master #6478 +/- ##
==========================================
- Coverage 78.33% 77.81% -0.53%
==========================================
Files 409 409
Lines 34840 35093 +253
==========================================
+ Hits 27291 27306 +15
- Misses 7549 7787 +238
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
nden
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6456
Resolves JP-2331
Description
This PR concerns a bug fix for MIRI MRS IFU cubes.
This PR fixes a bug in calculating the IFU footprint for cubes not created by calspec2 pipeline. In the calspec2 pipeline a single IFU cube is created for each exposure. This IFU cube will contain both channels on the detector. In this case (output_type = multi) and the spatial and spectral footprint on the sky are determined in assign_wcs and are the footprints for both channels. Assign_wcs stores the spatial footprint in input_model.meta.wcsinfo.s_region and the spectral footprint in input_model.meta.wcsinfo.spectral_region. Because the MIRI channels are designed to be roughly concentric the s_region in wcsinfo is correct for the larger FOV (channel 2 and channel 4). When creating IFU cubes that contain one band (or one channel) and for channel with the smaller FOV on the detector (channel 1 or channel 3) we do not want to use the footprint determined by assign_wcs because the footprint in wcsinfo is too large. In this case we need to calculate the footprint in cube_build using only data for the appropriate channel.
Checklist