8000 JP-2304: Fix arguments to DarkCurrentStep's make_output_path by tapastro · Pull Request #6450 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2304: Fix arguments to DarkCurrentStep's make_output_path #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 12, 2021
Merged

JP-2304: Fix arguments to DarkCurrentStep's make_output_path #6450

merged 5 commits into from
Nov 12, 2021

Conversation

tapastro
Copy link
Contributor
@tapastro tapastro commented Nov 11, 2021 •
edited
Loading

Closes #6402
Resolves JP-2304

Description

This PR changes the arguments provided to the DarkCurrentStep's make_output_path, such that the step parameter dark_output will now provide the frame-averaged darks in the filename specified, as per the documentation.

Aside: is anyone utilizing this output? With this sitting broken for so long, does this mean there are no tests verifying the contents of this file? 😨

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@tapastro tapastro added this to the Build 7.9 milestone Nov 11, 2021
@codecov
Copy link
codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #6450 (3dd502e) into master (2c3c03a) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
- Coverage   78.30%   78.27%   -0.04%     
==========================================
  Files         409      409              
  Lines       34740    34757      +17     
==========================================
+ Hits        27204    27206       +2     
- Misses       7536     7551      +15
Flag Coverage Δ *Carryforward flag
nightly 78.31% <66.66%> (ø) Carriedforward from c103bc0
unit 55.62% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/dark_current/dark_current_step.py 52.94% <33.33%> (-13.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3c03a...3dd502e. Read the comment docs.

stscieisenhamer
stscieisenhamer requested changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator
@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it was broken for so long, there probably is not a test. A test should be implemented.

hbushouse
hbushouse reviewed Nov 12, 2021
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Requisite change log request ...

@hbushouse
Copy link
Collaborator

A quick "grep dark_output *.py" of the regtest directory reveals no hits, hence this is not being tested. Sounds like someone just volunteered to create one.

@hbushouse
Copy link
Collaborator

Here's an example of an uncal exposure that uses NFRAMES>1 and hence could be used as input to a regtest:
/grp/jwst/ssb/bushouse/jwst_data/NIRCam/jw00312007001_02102_00001_nrcblong_uncal.fits
For the purpose of the regtest, you could process it up through the step in calwebb_detector1 preceding dark_current and then just run dark_current in the test.

@tapastro
Copy link
Contributor Author

Note: Two files will need to be added to artifactory for the new regression test.

@tapastro tapastro merged commit 6754f6b into spacetelescope:master Nov 12, 2021
@tapastro tapastro deleted the jp-2304-dark-output-error branch November 12, 2021 18:41
@tapastro
Copy link
Contributor Author

Files successfully uploaded to Artifactory.

@stscijgbot-jp stscijgbot-jp mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@hbushouse hbushouse Awaiting requested review from hbushouse

Assignees
No one assigned
Labels
dark_current
Projects
None yet
Milestone
Build 7.9
Development

Successfully merging this pull request may close these issues.

dark_current error when using dark_output - redundant spec parameter?
3 participants
@tapastro @hbushouse @stscieisenhamer
0