Fix crashes in skymatch when some footprints almost entirely overlap #6421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6421 +/- ##
==========================================
- Coverage 78.52% 78.32% -0.21%
==========================================
Files 407 407
Lines 34895 35020 +125
==========================================
+ Hits 27403 27428 +25
- Misses 7492 7592 +100
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Who knows... It worked for the other class and my hope is this will work for @jemorrison 's issue. Ideally, @jemorrison would clone my branch and test it with a data set. However, it is easier to just merge this and rebase @jemorrison 's PR and then maybe tweak tolerance. |
|
... and if tolerance needs adjustment, make another PR just for tolerance value. |
|
@mcara @hbushouse I grabbed the fixed PR (6421) and that fixed the problem with this set of data crashing. The data I was testing runs all the way through calimage3 |
|
@jemorrison Thanks for confirming this! |
* Removing data model dependency for average_dark_frames. * Unit tests are working, but save functionality for intermediate products needs to be fleshed out and step code needs to change to reflect the refactor. * Unit tests and regression tests are passing. * Fixing style issues. * Cleaning up the code and comments. * Style changes. * Making changes based on code review. * Changing class variable name to be more explicit. * Making changes to comments. * JP-2279: Update docs for resampled products (#6420) * JP-2279: Update docs for resampled products * add change log entry * Fix crashes in skymatch when some footprints almost entirely overlap (#6421) * Adding changes to the change log. * Removing data model dependency for average_dark_frames. Unit tests are working, but save functionality for intermediate products needs to be fleshed out and step code needs to change to reflect the refactor. Unit tests and regression tests are passing. Fixing style issues. Cleaning up the code and comments. Style changes. Making changes based on code review. Changing class variable name to be more explicit. Making changes to comments. Adding changes to the change log. Co-authored-by: Kenneth MacDonald <kmacdonald@itsd-osx55.hitronhub.home.stsci.edu> Co-authored-by: Howard Bushouse <bushouse@stsci.edu> Co-authored-by: Mihai Cara <mcara@users.noreply.github.com>
This PR extends the fix from #3557 to the
SkyImageclass in order to mitigate issues reported by @jemorrison in https://jira.stsci.edu/browse/JP-1670