8000 JP-2307: Edit README to avoid issues with default conda env and py3.10 by tapastro · Pull Request #6411 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2307: Edit README to avoid issues with default conda env and py3.10 #6411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

tapastro
Copy link
Contributor
@tapastro tapastro commented Oct 22, 2021

Closes #6409
Resolves JP-2307

Description

This PR advises the creation of conda environments with python set to 3.9, to avoid build conflicts with the default python==3.10.0. This can be reverted once conflicts no longer exist.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@tapastro tapastro added this to the Build 7.9 milestone Oct 22, 2021
@codecov
Copy link
codecov bot commented Oct 22, 2021

Codecov Report

Merging #6411 (d4134a2) into master (f69d493) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6411   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         408      408           
  Lines       34908    34908           
=======================================
  Hits        27413    27413           
  Misses       7495     7495           
Flag Coverage Δ *Carryforward flag
nightly 78.54% <ø> (ø) Carriedforward from 9818fe5
unit 56.34% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69d493...d4134a2. Read the comment docs.

README.md Outdated

### Installing latest releases

You can install the latest released version via `pip`. From a bash/zsh shell:

conda create -n <env_name> python
conda create -n <env_name> python==3.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda is a special flower and does not use the standard Python version comparison operators. What we really want here is a single =, not double, so that we get the latest python 3.9, i.e. 3.9.7 today. In Condaland, this is the same as specifying python~=3.9.0 using normal Python version comparison syntax.

Suggested change
conda create -n <env_name> python==3.9
conda create -n <env_name> python=3.9

Update elsewhere as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - tested the call, but didn't notice this wrinkle...

Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with all comments raised by @jdavies-st

@tapastro tapastro requested a review from hbushouse October 25, 2021 13:53
@tapastro tapastro merged commit 1c26772 into spacetelescope:master Oct 25, 2021
@tapastro tapastro deleted the jp-2307-conda-py39-docs branch October 25, 2021 15:13
nden pushed a commit to nden/jwst that referenced this pull request Nov 2, 2021
nden pushed a commit to nden/jwst that referenced this pull request Nov 2, 2021
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set python==3.9 in conda env creation until dependencies stable on 3.10.0
3 participants
0